-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP API version 1 #91
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bb69c95
Add HTTP API version 1
minwoox bf45eb7
Response with HttpStatus.CONFLICT when changeConflict
minwoox f4dad9b
Apply RequestConverter
minwoox 94fdbe9
address comments
minwoox bfd6fab
Remove unnecessary http query
minwoox e024669
Change package name
minwoox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
common/src/main/java/com/linecorp/centraldogma/internal/httpapi/v1/ChangeDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/* | ||
* Copyright 2017 LINE Corporation | ||
* | ||
* LINE Corporation licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package com.linecorp.centraldogma.internal.httpapi.v1; | ||
|
||
import static java.util.Objects.requireNonNull; | ||
|
||
import javax.annotation.Nullable; | ||
|
||
import com.fasterxml.jackson.annotation.JsonInclude; | ||
import com.fasterxml.jackson.annotation.JsonInclude.Include; | ||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
import com.google.common.base.MoreObjects; | ||
import com.google.common.base.MoreObjects.ToStringHelper; | ||
|
||
import com.linecorp.centraldogma.common.ChangeType; | ||
|
||
@JsonInclude(Include.NON_NULL) | ||
public class ChangeDto<T> { | ||
|
||
private final String path; | ||
|
||
private final ChangeType type; | ||
|
||
private final T content; | ||
|
||
public ChangeDto(String path, ChangeType type, @Nullable T content) { | ||
this.path = requireNonNull(path, "path"); | ||
this.type = requireNonNull(type, "type"); | ||
this.content = content; | ||
} | ||
|
||
@JsonProperty("path") | ||
public String path() { | ||
return path; | ||
} | ||
|
||
@JsonProperty("type") | ||
public ChangeType type() { | ||
return type; | ||
} | ||
|
||
@Nullable | ||
@JsonProperty("content") | ||
public T content() { | ||
return content; | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
final ToStringHelper stringHelper = MoreObjects.toStringHelper(this) | ||
.add("path", path()) | ||
.add("type", type()); | ||
if (content() != null) { | ||
stringHelper.add("content", content()); | ||
} | ||
|
||
return stringHelper.toString(); | ||
} | ||
} |
78 changes: 78 additions & 0 deletions
78
common/src/main/java/com/linecorp/centraldogma/internal/httpapi/v1/CommitDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
/* | ||
* Copyright 2017 LINE Corporation | ||
* | ||
* LINE Corporation licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package com.linecorp.centraldogma.internal.httpapi.v1; | ||
|
||
import static java.time.format.DateTimeFormatter.ISO_INSTANT; | ||
import static java.util.Objects.requireNonNull; | ||
|
||
import java.time.Instant; | ||
|
||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
import com.google.common.base.MoreObjects; | ||
|
||
import com.linecorp.centraldogma.common.Author; | ||
import com.linecorp.centraldogma.common.Commit; | ||
import com.linecorp.centraldogma.common.Revision; | ||
|
||
public class CommitDto { | ||
|
||
private final Revision revision; | ||
|
||
private final Author author; | ||
|
||
private final CommitMessageDto commitMessage; | ||
|
||
private final String pushedAt; | ||
|
||
public CommitDto(Commit commit) { | ||
requireNonNull(commit, "commit"); | ||
revision = commit.revision(); | ||
author = commit.author(); | ||
commitMessage = new CommitMessageDto(commit.summary(), commit.detail(), commit.markup()); | ||
pushedAt = ISO_INSTANT.format(Instant.ofEpochMilli(commit.when())); | ||
} | ||
|
||
@JsonProperty("revision") | ||
public Revision revision() { | ||
return revision; | ||
} | ||
|
||
@JsonProperty("author") | ||
public Author author() { | ||
return author; | ||
} | ||
|
||
@JsonProperty("pushedAt") | ||
public String pushedAt() { | ||
return pushedAt; | ||
} | ||
|
||
@JsonProperty("commitMessage") | ||
public CommitMessageDto commitMessage() { | ||
return commitMessage; | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return MoreObjects.toStringHelper(this) | ||
.add("revision", revision()) | ||
.add("author", author()) | ||
.add("commitMessage", commitMessage()) | ||
.add("pushedAt", pushedAt()) | ||
.toString(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we treat
.JSON
as JSON? IIRC we only accept.json
, but my memory may not be correct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know. That was just my decision. I will remove the
(?i)
:-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it seems case-insensitive. In
EntryType
:Sorry!