Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Add an option to control the default size of the image #22

Merged
merged 4 commits into from
Mar 14, 2019

Conversation

yutannihilation
Copy link
Contributor

@yutannihilation yutannihilation commented Mar 14, 2019

Fix #21

Internal

Currently, conflr sets the height to 400 on all images that don't have height attribute; if an image has its own heights and width, those are respected by the change of #7.

This PR changes to set width to 600 on on all images that don't have width attribute. Probably, this changes the visual appearance, but setting width is in line with what the Confluence's editor does.

スクリーンショット 2019-03-14 10 32 42

User visible changes

This PR adds a new argument image_size_default to confl_post_page() and confl_update_page(). When this is NULL, no width or height will be set, which means the images will be displayed as the original sizes.

But the parameter is not directly exposed to the addin. Instead, a simple checkbox is added for simplicity. If this is checked, image_size_default = NULL is used.

スクリーンショット 2019-03-14 10 37 26

TODO

  • Update README in another PR

@yutannihilation yutannihilation merged commit 06b8d88 into master Mar 14, 2019
@yutannihilation yutannihilation deleted the feature/use-original-size branch March 14, 2019 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant