This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
Add an option to control the default size of the image #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21
Internal
Currently, conflr sets the height to 400 on all images that don't have height attribute; if an image has its own heights and width, those are respected by the change of #7.
This PR changes to set width to 600 on on all images that don't have width attribute. Probably, this changes the visual appearance, but setting width is in line with what the Confluence's editor does.
User visible changes
This PR adds a new argument
image_size_default
toconfl_post_page()
andconfl_update_page()
. When this isNULL
, nowidth
orheight
will be set, which means the images will be displayed as the original sizes.But the parameter is not directly exposed to the addin. Instead, a simple checkbox is added for simplicity. If this is checked,
image_size_default = NULL
is used.TODO