fix multiple return error case; fix expire time unit issue #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onevcat
reviewed
Mar 6, 2020
| @@ -21,7 +21,7 @@ data class AccessToken( | |||
| val accessToken = loginResult.lineCredential?.accessToken ?: return null | |||
| return AccessToken( | |||
| accessToken.tokenString, | |||
| accessToken.expiresInMillis, | |||
| (accessToken.estimatedExpirationTimeMillis - System.currentTimeMillis()) / 1000, | |||
| lineIdTokenString | |||
There was a problem hiding this comment.
To algin the documentation and iOS implementation, please return the expires_in which we received from server when issuing the token. (The number is fixed and counted from when the server issued the token).
There was a problem hiding this comment.
Here is another explanation on how to use these expires_in values. Basically, we just provide what received from the server as a simple relaying, and leave the framework users to determine how they would want to use or store them.
tsairene
reviewed
Mar 6, 2020
| ) | ||
| loginResult?.error(resultCode.toString(), "login failed", null) | ||
| loginResult = null | ||
| return true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.