Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change format of git tags so the library is go module aware #101

Closed
m90 opened this issue Aug 28, 2018 · 2 comments
Closed

Change format of git tags so the library is go module aware #101

m90 opened this issue Aug 28, 2018 · 2 comments

Comments

@m90
Copy link
Contributor

m90 commented Aug 28, 2018

If you currently install the package in a Go 1.11 module aware environment, the existing git tags will be ignored as they are expected to start with a v, i.e. 3.0.0 should be v3.0.0 instead: https://github.com/golang/go/wiki/Modules#modules

Is it possible to start tagging the releases in this way, so that it can be properly consumed as a module as well?

@suzuki-shunsuke
Copy link
Contributor

Thank you for the issue!
I have created tags started with "v".
https://github.com/line/line-bot-sdk-go/tags

And we will created tags started with "v" from the next time.

Thank you again.

@m90
Copy link
Contributor Author

m90 commented Aug 28, 2018

Thanks, I'm already consuming the tagged version!

@m90 m90 closed this as completed Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants