Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validating message objects APIs #328

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Oct 29, 2022

Resolve #327

@Yang-33 Yang-33 marked this pull request as ready for review October 29, 2022 16:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2022

Codecov Report

Base: 79.00% // Head: 78.69% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (879ef0f) compared to base (c173a44).
Patch coverage: 69.56% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   79.00%   78.69%   -0.31%     
==========================================
  Files          38       39       +1     
  Lines        3443     3558     +115     
==========================================
+ Hits         2720     2800      +80     
- Misses        553      578      +25     
- Partials      170      180      +10     
Impacted Files Coverage Δ
linebot/client.go 69.46% <ø> (ø)
linebot/validate_message.go 69.56% <69.56%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit 467dc55 into line:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validating message objects
3 participants