Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use POST method for Test Webhook endpoiont #356

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

unnoy
Copy link
Contributor

@unnoy unnoy commented Sep 12, 2023

i got an error below when consuming TestWebhook endpoint.
"failed":"linebot: APIError 405 The request method, 'GET', is not supported

it seems only post method is allowed according to the doc.
https://developers.line.biz/en/reference/messaging-api/#test-webhook-endpoint

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (df06aa0) 78.93% compared to head (84f13cc) 78.93%.
Report is 1 commits behind head on master.

❗ Current head 84f13cc differs from pull request most recent head 283255b. Consider uploading reports for the commit 283255b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files          40       40           
  Lines        3712     3712           
=======================================
  Hits         2930     2930           
  Misses        590      590           
  Partials      192      192           
Files Changed Coverage Δ
linebot/webhook.go 86.30% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yang-33 Yang-33 merged commit 0706a9a into line:master Sep 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants