Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore null field in UnmarshalJSON. #382

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Ignore null field in UnmarshalJSON. #382

merged 1 commit into from
Nov 1, 2023

Conversation

tokuhirom
Copy link
Member

No description provided.

Yang-33
Yang-33 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether unmarshalling is necessary or not seems feasible using var.required.

However, it's not a big practical issue, so LGTM!

@tokuhirom tokuhirom merged commit 28c1986 into line:master Nov 1, 2023
5 checks passed
@tokuhirom tokuhirom deleted the ignore-nulls branch November 1, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yang-33 Yang-33 Yang-33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tokuhirom @Yang-33