Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some version dependencies for docker container #92

Merged
merged 2 commits into from
Jul 27, 2018

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Jul 18, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 18, 2018

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   47.26%   47.26%           
=======================================
  Files          76       76           
  Lines        2503     2503           
=======================================
  Hits         1183     1183           
  Misses       1320     1320

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c430506...d68efde. Read the comment docs.

@@ -7,6 +7,17 @@ if [ "${1:0:1}" = '-' ]; then
fi

case "$1" in
docker-compose-bootstrap)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should handle the same cases as #71

@kfdm kfdm merged commit fcb54cc into line:master Jul 27, 2018
@kfdm kfdm deleted the docker-fix branch July 27, 2018 06:09
@seoester
Copy link
Contributor

seoester commented Jul 27, 2018

Great stuff! This should be really useful for compose and docker in general.

I had the idea of making the parameters configurable via env vars. I'll create a PR the coming days.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants