Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip text when SkipEncoding is present #77

Merged
merged 3 commits into from
Aug 14, 2024
Merged

fix: skip text when SkipEncoding is present #77

merged 3 commits into from
Aug 14, 2024

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Aug 14, 2024 •
edited
Loading

Text is now properly skipped when a SkipEncoding component is present.

@simbleau simbleau requested a review from DJMcNab August 14, 2024 05:12
DJMcNab
DJMcNab reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any real objection with the content of the PR, but the packaging is quite deceptive. If this PR had a title such as:

Skip text when needed and release as 0.6.1

I'd be happy to approve.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@simbleau simbleau changed the title fix: text is skipped properly Skip text when needed and release as 0.6.1 Aug 14, 2024
@simbleau simbleau requested a review from DJMcNab August 14, 2024 13:16
@simbleau simbleau changed the title Skip text when needed and release as 0.6.1 fix: skip text when SkipEncoding is present Aug 14, 2024
@simbleau simbleau mentioned this pull request Aug 14, 2024
Merged
@simbleau simbleau added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 941b781 Aug 14, 2024
6 checks passed
@simbleau simbleau deleted the v0.6.1 branch August 14, 2024 13:33
github-merge-queue bot pushed a commit that referenced this pull request Aug 14, 2024
@simbleau @DJMcNab
v0.6.1 (#79)
21dd9f6 
Must merge #77 first.

---------

Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simbleau @DJMcNab