Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text integration tracking issue #1192

Open
4 of 7 tasks
cmyr opened this issue Sep 8, 2020 · 2 comments
Open
4 of 7 tasks

Text integration tracking issue #1192

cmyr opened this issue Sep 8, 2020 · 2 comments
Assignees
@cmyr
Labels
enhancement adds or requests a new feature

Comments

@cmyr
Copy link
Member

cmyr commented Sep 8, 2020 •
edited
Loading

A tracking issue, largely for my own benefit, detailing the various bits of work involved in incorporating the new piet text stuff into druid.
@cmyr cmyr added the enhancement adds or requests a new feature label Sep 8, 2020
@cmyr cmyr self-assigned this Sep 8, 2020
@cmyr cmyr mentioned this issue Sep 8, 2020
Merged
cmyr added a commit that referenced this issue Sep 10, 2020
@cmyr
Expose wrap width in TextLayout, add LineBreaking options
8b41c0c 
With this patch, the TextLayout object can now be given a width
for wrapping words. This is exposed in the Label via a new
LineBreaking enum, with three options. With LineBreaking::WordWrap,
the TextLayout's wrap-width is set to the maximum width of the label's
BoxConstraints, and lines are broken appropriately. The other two
options (LineBreaking::Overflow and LineBreaking::Clip) both disable
line-breaking; in the former case if text exceeds the width of
the label it is painted outside of the label's bounds, and in the
latter case the text is clipped to the bounds of the label.

It would be nice if, in the clipping case, we could use a gradient
mask or something to fade the edges of the clipped text, but I don't
believe this is currently possible in piet. A simple alternative
of drawing a gradient from (transparent -> label background color)
doesn't work, because label's do not have an explicit background color,
which I think is also correct.

progress on #1192
cmyr added a commit that referenced this issue Sep 10, 2020
@cmyr
Expose wrap width in TextLayout, add LineBreaking options
9a3a716 
With this patch, the TextLayout object can now be given a width
for wrapping words. This is exposed in the Label via a new
LineBreaking enum, with three options. With LineBreaking::WordWrap,
the TextLayout's wrap-width is set to the maximum width of the label's
BoxConstraints, and lines are broken appropriately. The other two
options (LineBreaking::Overflow and LineBreaking::Clip) both disable
line-breaking; in the former case if text exceeds the width of
the label it is painted outside of the label's bounds, and in the
latter case the text is clipped to the bounds of the label.

It would be nice if, in the clipping case, we could use a gradient
mask or something to fade the edges of the clipped text, but I don't
believe this is currently possible in piet. A simple alternative
of drawing a gradient from (transparent -> label background color)
doesn't work, because label's do not have an explicit background color,
which I think is also correct.

progress on #1192
cmyr added a commit that referenced this issue Sep 10, 2020
@cmyr
Expose wrap width in TextLayout, add LineBreaking options
ce1cbd8 
With this patch, the TextLayout object can now be given a width
for wrapping words. This is exposed in the Label via a new
LineBreaking enum, with three options. With LineBreaking::WordWrap,
the TextLayout's wrap-width is set to the maximum width of the label's
BoxConstraints, and lines are broken appropriately. The other two
options (LineBreaking::Overflow and LineBreaking::Clip) both disable
line-breaking; in the former case if text exceeds the width of
the label it is painted outside of the label's bounds, and in the
latter case the text is clipped to the bounds of the label.

It would be nice if, in the clipping case, we could use a gradient
mask or something to fade the edges of the clipped text, but I don't
believe this is currently possible in piet. A simple alternative
of drawing a gradient from (transparent -> label background color)
doesn't work, because label's do not have an explicit background color,
which I think is also correct.

progress on #1192
cmyr added a commit that referenced this issue Sep 11, 2020
@cmyr
Expose wrap width in TextLayout, add LineBreaking options
7261854 
With this patch, the TextLayout object can now be given a width
for wrapping words. This is exposed in the Label via a new
LineBreaking enum, with three options. With LineBreaking::WordWrap,
the TextLayout's wrap-width is set to the maximum width of the label's
BoxConstraints, and lines are broken appropriately. The other two
options (LineBreaking::Overflow and LineBreaking::Clip) both disable
line-breaking; in the former case if text exceeds the width of
the label it is painted outside of the label's bounds, and in the
latter case the text is clipped to the bounds of the label.

It would be nice if, in the clipping case, we could use a gradient
mask or something to fade the edges of the clipped text, but I don't
believe this is currently possible in piet. A simple alternative
of drawing a gradient from (transparent -> label background color)
doesn't work, because label's do not have an explicit background color,
which I think is also correct.

progress on #1192
cmyr added a commit that referenced this issue Sep 11, 2020
@cmyr
Expose wrap width in TextLayout, add LineBreaking options
bfe33a9 
With this patch, the TextLayout object can now be given a width
for wrapping words. This is exposed in the Label via a new
LineBreaking enum, with three options. With LineBreaking::WordWrap,
the TextLayout's wrap-width is set to the maximum width of the label's
BoxConstraints, and lines are broken appropriately. The other two
options (LineBreaking::Overflow and LineBreaking::Clip) both disable
line-breaking; in the former case if text exceeds the width of
the label it is painted outside of the label's bounds, and in the
latter case the text is clipped to the bounds of the label.

It would be nice if, in the clipping case, we could use a gradient
mask or something to fade the edges of the clipped text, but I don't
believe this is currently possible in piet. A simple alternative
of drawing a gradient from (transparent -> label background color)
doesn't work, because label's do not have an explicit background color,
which I think is also correct.

progress on #1192
@sysint64
Copy link
Contributor

Probably known issue, but just in case - there are a lot of TextAlignment not supported by cairo toy text messages.

In my realtime system, the time needed to render a frame dropped from 1ms to 188ms because of that :(

@sysint64
Copy link
Contributor

sysint64 commented Sep 13, 2020 •
edited
Loading

Well, that's funny, I have steady 6ms-10ms if I run from the terminal, but 188ms if I run from emacs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmyr cmyr

Labels
enhancement adds or requests a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sysint64 @cmyr