Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for a lens(ignore) attribute. #1133

Merged
merged 4 commits into from
Aug 18, 2020
Merged

Adds support for a lens(ignore) attribute. #1133

merged 4 commits into from
Aug 18, 2020

Conversation

jneem
Copy link
Collaborator

@jneem jneem commented Aug 16, 2020

This isn't terribly important because #[len(name="_ignore")] is a decent work-around, but having an explicit ignore attribute feels cleaner to me. Also, I think factoring out the data attributes and the lens attributes is something we'll want eventually anyway.

Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these attributes should be documented! Feel free though to only document the one you added, the others can be added in a separate PR.

Also, the changlog entry is missing, code wise it looks good to me.

@luleyleo luleyleo added the S-waiting-on-author waits for changes from the submitter label Aug 17, 2020
@jneem jneem requested a review from luleyleo August 18, 2020 00:56
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@luleyleo luleyleo removed the S-waiting-on-author waits for changes from the submitter label Aug 18, 2020
@jneem jneem merged commit 859cb0b into linebender:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants