Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the close hook for x11 #1204

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

psychon
Copy link
Contributor

@psychon psychon commented Sep 9, 2020

Commit 7b6f83e added a close request hook and implemented it. This
commit implements this request for the x11 platform. Either I did
something wrong, or it is way easier to do this on x11 than on Gtk.

Signed-off-by: Uli Schlachter psychon@znc.in

CC @jneem

Edit: Related to #1159

Commit 7b6f83e added a close request hook and implemented it. This
commit implements this request for the x11 platform. Either I did
something wrong, or it is way easier to do this on x11 than on Gtk.

Signed-off-by: Uli Schlachter <psychon@znc.in>
I feel like my one line change does not deserve a proper entry in
CHANGELOG.md, so this is added to the already existing entry.

Signed-off-by: Uli Schlachter <psychon@znc.in>
Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Yeah, in GTK you need to do some extra bookkeeping to figure out when to inhibit the default behavior. Sometimes it's nice to just not have any default behavior to deal with :)

@jneem jneem merged commit f811db5 into linebender:master Sep 9, 2020
@psychon psychon deleted the impl_request_close_for_x11 branch September 9, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants