Expose scope state #1607
Closed
Expose scope state #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly for composite widgets that contain a scope: using this they can affect the widgets inside the scope. Using this facilty, allow getting and setting the tab index of a Tabs widget. This offers part of a solution to linebender#1390, although it is in terms of the index and not the key.
cmyr
approved these changes
Feb 23, 2021
| @@ -20,6 +20,8 @@ You can find its changes [documented below](#070---2021-01-01). | |||
| - WindowSizePolicy: allow windows to be sized by their content ([#1532] by [@rjwittams]) | |||
| - Implemented `Data` for more datatypes from `std` ([#1534] by [@derekdreery]) | |||
| - Shell: windows implementation from content_insets ([#1592] by [@HoNile]) | |||
| - Scope: expose scoped state using state() and state_mut() ([#XXXX] by [@rjwittams] | |||
| - Tabs: allow getting and setting the tab index of a Tabs widget ([#XXXX] by [@rjwittams] | |||
There was a problem hiding this comment.
will want to fix this up before merging
Comment on lines
+217
to
+218
| /// This allows you to access the content of the Scopes state from | ||
| /// outside the widget. |
There was a problem hiding this comment.
Suggested change
| /// This allows you to access the content of the Scopes state from | |
| /// outside the widget. | |
| /// A reference to the contents of the `Scope`'s state. | |
| /// | |
| /// This allows you to access the content from outside the widget. |
Comment on lines
+227
to
+230
| /// This allows you to mutably access the content of the Scopes state from | ||
| /// outside the widget. Mainly useful for composite widgets. Note that | ||
| /// if you modify the state through this reference, the Scope will not | ||
| /// call update on its children until the next event it receives. |
There was a problem hiding this comment.
Suggested change
| /// This allows you to mutably access the content of the Scopes state from | |
| /// outside the widget. Mainly useful for composite widgets. Note that | |
| /// if you modify the state through this reference, the Scope will not | |
| /// call update on its children until the next event it receives. | |
| /// A mutable reference to the contents of the [`Scope`]'s state. | |
| /// | |
| /// This allows you to mutably access the content of the `Scope`' s state from | |
| /// outside the widget. Mainly useful for composite widgets. | |
| /// | |
| /// # Note: | |
| /// | |
| /// If you modify the state through this reference, the Scope will not | |
| /// call update on its children until the next event it receives. |
| @@ -896,6 +906,12 @@ impl<TP: TabsPolicy> Tabs<TP> { | |||
| self | |||
| } | |||
|
|
|||
| /// Return this Tabs widget with the specified (zero based) tab index | |||
There was a problem hiding this comment.
Suggested change
| /// Return this Tabs widget with the specified (zero based) tab index | |
| /// A builder-style method to specify the (zero-based) index of the selected tab. |
(is this correct?)
| TP::add_tab(tabs, name, child) | ||
| } else { | ||
| tracing::warn!("Can't add static tabs to a running or complete tabs instance!") | ||
| } | ||
| } | ||
|
|
||
| fn make_scope(&self, tabs_from_data: TP) -> WidgetPod<TP::Input, TabsScope<TP>> { | ||
| /// Get the currently selected (zero-based) tab index. |
There was a problem hiding this comment.
Suggested change
| /// Get the currently selected (zero-based) tab index. | |
| /// The (zero-based) index of the currently selected tab. |
Comment on lines
+943
to
+945
| /// Set the selected (zero-based) tab index, this tab will become visible if it exists. | ||
| /// Animated transitions will apply as if clicking the tab bar if they are enabled and the | ||
| /// Tabs widget is laid out. |
There was a problem hiding this comment.
Suggested change
| /// Set the selected (zero-based) tab index, this tab will become visible if it exists. | |
| /// Animated transitions will apply as if clicking the tab bar if they are enabled and the | |
| /// Tabs widget is laid out. | |
| /// Set the selected (zero-based) tab index. | |
| /// | |
| /// This tab will become visible if it exists. If animations are enabled | |
| /// (and the widget is laid out), the tab transition will be animated. |
|
Cheers for the comments, I'll have a look later on! |
|
@rjwittams Can you integrate Colin's changes and rebase this branch? If you don't work on this anymore, I can also take ownership of the PR and do the changes myself. Either way, I think this is ready to merge, minor changes aside. Colin seemed to approve, and the project hasn't really changed direction since. |
Merged
|
I think this is superseded by #2082. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly for composite widgets that contain a scope: using this they can affect the widgets inside the scope.
Using this facilty, allow getting and setting the tab index of a Tabs widget.
This offers part of a solution to #1390, although it is in terms of the index and not the key.