-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable widgets #1620
Closed
Closed
Disable widgets #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Druid
newly disabled widgets now wont get focused and newly enabled widgets can now get focus
This was way to complicated and didn't work as well as expected. I'm closing this Issue for now. |
@xarvic this is a definitely a harder problem than it might seem like at first, happy to talk about it sometime if you'd like. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of a disabled state for widgets (issue: #746 ).
It adds the following:
set_enabled(bool)
forEventCtx
andUpdateCtx
which changes if the state of the current widget is "manually disabled".is_enabled() -> bool
for all Context which returns false if this widget or any of its ancestors is manually disabled".LifeCycle::EnabledChanged(bool)
which is called every time whenis_enabled()
would return a different value than before.The behaviour of focusing widgets was changed. The
WidgetPod
now has fieldcan_auto_focus
that is used to determine if this widget should get focused as a result tofocus_pref
orfocus_next
. If the widget is focused when it gets disabled, it resigns the focus and is`nt able to request the focus until it is enabled again.While disabled, a widget recieves only some of the event. MouseMove, MouseDown, MouseUp, Zoom and MouseWheel are blocked. But i`m not sure if this is desirable, maybe a scroll widget should still be able to scroll its content.
Problems:
Todo: