-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gtk #1845
Bump gtk #1845
Conversation
@@ -15,7 +15,7 @@ default-target = "x86_64-pc-windows-msvc" | |||
|
|||
[features] | |||
default = ["gtk"] | |||
gtk = ["gio", "gdk", "gdk-sys", "glib", "glib-sys", "gtk-sys", "gtk-rs", "gdk-pixbuf"] | |||
gtk = ["gdk-sys", "glib-sys", "gtk-sys", "gtk-rs"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need -sys neither, they are re-exported as ffi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Rebase and merge?
Blocked on piet version bump. |
@JAicewizard I've released piet |
rebased, CI seems to have issues but it compiles fine locally. |
Build time hasn't changed:
before:
Finished dev [unoptimized + debuginfo] target(s) in 1m 02s
after:
Finished dev [unoptimized + debuginfo] target(s) in 1m 06s
There are a couple less dependencies, but those didn't seem to have any effect on total build times. This also removed direct dependencies from druid-shell. This will reduce maintenance effort a bit.