Add detection for dark or light theme. #2204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #2196 (comment)
The windows API does not actually detect dark mode but forces it on. This is the simplest way to detect dark mode without depending on UWP APIs that require windows-rs. If it fails to read the registry it defaults to a light theme.
I tested this locally and the app will use the dark theme if the user's OS is set to dark otherwise it uses a light theme.
It does not detect this if the settings change while running the app but without UWP APIs I believe I would have to poll the registry which does not feel like a great solution.
Thanks!