-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code examples to the docs of TextBox #2284
Conversation
Thank you for your effort! I haven't looked at the substance of this PR yet, but please do the following:
|
@xStrom thanks for helping me! I think I did it all good with the change log, let me know if there is more to add or if I put something in an incorrect place! |
CHANGELOG.md
Outdated
@@ -150,6 +150,7 @@ You can find its changes [documented below](#070---2021-01-01). | |||
- Update docs of `RawLabel`: does not require `ArcStr`([#1886] by [@Maan2003]) | |||
- Fix `Controller` links for `Click` ([#2158] by [@yrns]) | |||
- Delete inaccurate line for `KeyEvent` ([#2247] by [@amtep]) | |||
- Added examples in `TextBox` ([#2284] by [@ThomasMcAndrew]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure if github markdown's links are case sensitive. But probably "andrew" is better just to be safe...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jneem Good catch, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one little nitpick but otherwise looks good.
druid/src/widget/textbox.rs
Outdated
/// | ||
/// //will wrap for each line | ||
/// let wrap_multi_line_text_box = TextBox::multiline() | ||
/// .with_line_wrapping(true) // this is default can be removed for the same result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add either a comma or and after the word default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is now good to merge.
Hey all,
I am new to Druid and fairly new to rust in general but I like this UI framework the best. I wanted some documentation so I figured I could just write it.
I can do it for all of them but I wanted to get one done and get feedback on how you want the documentation to look.
I think examples are the most helpful for myself so I focused on that the most.
Please give feedback I want to make the documentation best that it can be and I am new-ish to writing documentation for others, so critiques are helpful.