Respect scale when setting window position during creation. #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xStrom
added
shell/win
jneem
approved these changes
Dec 1, 2022
|
I think in this case it's best to merge and see if someone who uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #2286 by @Steve-xmh our current Windows backend doesn't respect scale when setting the window position during creation. Indeed there was even a TODO note to that effect in the code.
This PR addresses that shortcoming. I also refactored some of that position/size scaling code to be more unified. Previously there were different rounding strategies used in different code paths for example. This can lead to really tricky to debug issues.