Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed window creation position at high-dpi screen #2286

Closed
wants to merge 4 commits into from

Conversation

Steve-xmh
Copy link
Contributor

Fixed windows position at high-dpi screen when creating window.

Because I've just noticed that when I need to make window center on high-dpi screen the window will shift to the upper left corner. I've just checked the code for a while and tried to simply fix it.

Fixed position at high-dpi screen when creating window.
@jneem jneem added the 0.8 label Nov 26, 2022
@xStrom xStrom added shell/win concerns the Windows backend S-needs-review waits for review labels Nov 27, 2022
@xStrom
Copy link
Member

xStrom commented Nov 27, 2022

Thank you for your effort!

I haven't looked at the substance of this PR yet, but please do the following:

  • Rebase on master so that we can run the tests (The errors seen here are fixed in master)
  • Run cargo fmt

@xStrom
Copy link
Member

xStrom commented Dec 1, 2022

Thanks again for tackling this issue. This PR here does address the symptom but as I was looking into the problem I found that we need a deeper fix.

That fix is now available in #2296. In my own testing it solves this issue. Perhaps you could see if it solves it for you too?

@xStrom xStrom added S-blocked waits for another PR or dependency and removed S-needs-review waits for review 0.8 labels Dec 1, 2022
@Steve-xmh
Copy link
Contributor Author

Thanks again for tackling this issue. This PR here does address the symptom but as I was looking into the problem I found that we need a deeper fix.

That fix is now available in #2296. In my own testing it solves this issue. Perhaps you could see if it solves it for you too?

Thanks a lot! Your code also works on my code. So I think I should close this pr for your further modification since my patch is too simple (As I'm new at contributing code at Druid).

Anyway, thanks a lot for your work on this simple patch!

@Steve-xmh Steve-xmh closed this Dec 1, 2022
@xStrom xStrom removed the S-blocked waits for another PR or dependency label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell/win concerns the Windows backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants