Unify window size rounding strategy #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xStrom
added
shell/mac
jneem
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been some divergence in the rounding strategy of window sizes. This PR unifies the strategy on Windows and GTK.
(On macOS the OS controls it. I didn't look at X11/Wayland in much depth.)
Before this PR some places used
ScaledArea::from_dp(Size::expandunder the hood) and others usedf64::round. Now all the window size scaling is done viaScaledArea::from_dp. A unified strategy will help cut down on obscure bugs. This will also allow for easier strategy changes in the future if there is a need, as we can just change that one method.This PR also contains:
get_sizenot being in display points on Windows (backport of glazier#35)get_scaleon macOS (backport of glazier#36)