Remove outdated documentation in LifeCycle events #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprocklem
changed the title
The documentation previously included an outdated claim that users interested in automatic focus should call `register_for_focus()` in response to `LifeCycle::WidgetAdded`. This is no longer true since the addition of `LifeCycle::BuildFocusChain`, so the relevant section was deleted. Additionally, this commit fixes a minor spelling error in the documentation of the latter.
|
Sorry about the delay on this pull request. Its been an unexpectedly busy few days. |
xStrom
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation previously included an outdated claim that users interested in automatic focus should call
register_for_focus()in response toLifeCycle::WidgetAdded. This is no longer true since the addition ofLifeCycle::BuildFocusChain, so the relevant section was deleted. Additionally, this commit fixes a minor spelling error in the documentation of the latter.Fixes #2318 .