Stop visual artifacts from appearing when using input fields #2381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills invalid rects with a reset color instead of clearing them to fix #2367 which is is easily reproducible on Mac almost anywhere that uses an input field (I'm on M1 Macbook).
This PR partially reverts #1617 to restore the invalidation painting to use
piet.fill
instead ofpiet.clear
.I tracked down the issue by bisecting but I don't know why this fixes the issue or if the invalidation painting should have ever used
clear
in the first place. Perhaps there is a bug with theclear
method.🐛 Bug:
![Screen Recording 2023-06-03 at 10 48 13 AM](https://private-user-images.githubusercontent.com/61894094/243125879-358f7a3b-c122-4340-8b5a-2536535105c7.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1MjU1NzMsIm5iZiI6MTcyNTUyNTI3MywicGF0aCI6Ii82MTg5NDA5NC8yNDMxMjU4NzktMzU4ZjdhM2ItYzEyMi00MzQwLThiNWEtMjUzNjUzNTEwNWM3LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA1VDA4MzQzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgwNmFjNzEwMzVkNDNjZjgzZTk1YTZkN2Q3NjlkY2I0OTI0MTFhNWQ1Y2ZlYjIzMGUyM2I5NDE1ZWFkMWQ4ZDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eJJJf4bNRnpe2HPfaZLHk5aW_JS8UrLRt301GVBMylc)
Repro steps in issue
Boredom warning: the GIF below is in like slowmo for some reason.
how tested
Manually, both examples in 2367 appear resolved and the
transparency.rs
example remains unchanged after the fix.