Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash of white at window edge while resizing on Windows. #915

Merged
merged 1 commit into from
May 22, 2020

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented May 11, 2020

On Windows 7 when resizing there are flashes of white background, because the content resize lags behind the window resize. With this change the background coloring task is delegated to druid, which it already does.

This might also have an effect on #914 although given that the initial app opening flash is harder to reproduce, it will take time to find out whether that is solved.

@xStrom xStrom added shell/win concerns the Windows backend S-needs-review waits for review labels May 11, 2020
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Note that I'm not able to reproduce the artifacts on resizing on my Windows 7 test machine, but I'm willing to believe there are variations. Thanks!

@xStrom xStrom removed the S-needs-review waits for review label May 22, 2020
@xStrom xStrom merged commit 1d1b97b into linebender:master May 22, 2020
@xStrom xStrom deleted the shell-bg branch May 22, 2020 17:06
@xStrom xStrom mentioned this pull request Jun 19, 2020
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell/win concerns the Windows backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants