Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code for Identifier match Name #259

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Make code for Identifier match Name #259

merged 1 commit into from
Feb 19, 2022

Conversation

madig
Copy link
Collaborator

@madig madig commented Feb 18, 2022 •
edited
Loading

Both structures are the same, except for the validity criteria.

Leaving the custom serialize because we run a debug_assert. Or should we scrap that one?

@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing f165f16 against eb63537

target old size new size difference
target/release/examples/load_save 1.93 MB 1.93 MB 120 Bytes (0.01%)
target/debug/examples/load_save 8.66 MB 8.66 MB -528 Bytes (-0.01%)

Base automatically changed from use-Name-for-glyph-parts to master February 18, 2022 22:50
cmyr
cmyr approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@madig madig merged commit 6351783 into master Feb 19, 2022
@madig madig deleted the identifiers-mimic-names branch February 19, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madig @cmyr