LayerSet: add retain & remove_empty_layers #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
reviewed
Dec 8, 2022
|
|
||
| /// Removes any layers that contain no glyphs | ||
| pub fn remove_empty_layers(&mut self) { | ||
| self.retain(|l| !l.is_empty()); |
There was a problem hiding this comment.
we should probably also guard against the default layer being removed here?
nevermind I get it 😇
|
thanks! if you want a new release, feel free to make a PR bumping the version to 0.8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is functionality I have a use for and can't implement anywhere except in the library, given
layersis a private member ofLayerSetI don't like that with
retainI check every layer to see if its name matches the default, but there's no good way (without allocating) to 'skip one and then retain' that I'm aware ofSimple positive test case added for each method