Add support to drawing text with gradient brush (piet-coregraphics) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunogouveia
force-pushed
the
cg-text-gradient
branch
from
ee64360
to
755be8a
Compare
cmyr
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I was looking into adding support to Core Graphics backend a few months ago (https://github.com/brunogouveia/piet/commits/piet-core-graphics), but I never had the time to finish.
I looked into the current core graphics backend implementation and I noticed text rendering with gradient brushes was missing, so I created this PR adding gradient support, that uses the same approach I used on my branch: set
text drawing modeto clip and render the gradient afterwards.