-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for running with cairo #97
Conversation
- Related to linebender#9 - Related to linebender#33
Hi everyone, |
"piet-test", | ||
"piet-web", | ||
"piet-web/examples/basic" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the significance of this change?
edit: oh, maybe #33 (comment)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's where it came from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it also makes sense to remove piet-cairo from this list and have users explicitly choose a backend with --features.
Thanks for this, cleanup is good and documentation is even better. One thing I would like to make sure is that this doesn't influence what gets built in CI; additionally we might want to also be building cairo in CI on windows? I'm not sure how much of a headache that would be. |
I haven't used Azure before, but it looks like what runs in CI is controlled by ci/test.yml? Since the commands already have Line 16 in 02207a9
For adding cairo, what do you think about just adding a curl line or similar to install-rust.yml to download the prebuilt release listed above? |
okay, |
direct2d::math
#33