Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for running with cairo #97

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Conversation

dianarg
Copy link
Contributor

@dianarg dianarg commented Oct 31, 2019

@dianarg
Copy link
Contributor Author

dianarg commented Oct 31, 2019

Hi everyone,
I tested this on Windows 10 and Ubuntu Linux. Getting the cairo library on Windows was slightly more complicated, but the release rylev mentioned worked fine for me (https://github.com/preshing/cairo-windows).

"piet-test",
"piet-web",
"piet-web/examples/basic"
]
Copy link
Member

@cmyr cmyr Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the significance of this change?

edit: oh, maybe #33 (comment)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's where it came from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it also makes sense to remove piet-cairo from this list and have users explicitly choose a backend with --features.

@cmyr
Copy link
Member

cmyr commented Nov 1, 2019

Thanks for this, cleanup is good and documentation is even better. One thing I would like to make sure is that this doesn't influence what gets built in CI; additionally we might want to also be building cairo in CI on windows? I'm not sure how much of a headache that would be.

@dianarg
Copy link
Contributor Author

dianarg commented Nov 1, 2019

I haven't used Azure before, but it looks like what runs in CI is controlled by ci/test.yml? Since the commands already have --all, I think it's already building everything (except cairo) for Windows.

cargo +${{parameters.toolchain}} check --all --exclude piet-cairo || exit

For adding cairo, what do you think about just adding a curl line or similar to install-rust.yml to download the prebuilt release listed above?

@cmyr
Copy link
Member

cmyr commented Nov 1, 2019

okay, --all sounds good. And yea, we would do something like download prebuilt binaries. I don't think that's critical though, and it doesn't need to be part of this PR; if you want to play around with it you're more than welcome but no pressure. :)

@cmyr cmyr merged commit 161f50f into linebender:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants