Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move text into reference folder #433

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Move text into reference folder #433

merged 2 commits into from
Jul 18, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Jul 17, 2024

This was imported in #241

See also #masonry > text vs text2

We do want to sort out text properly, see #337, so I'm keeping the reference code around.

waywardmonkeys
waywardmonkeys approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of my remaining papercuts being fixed!

The only comment that I have is that perhaps it could be moved out of the src directory, but no big difference.

@DJMcNab DJMcNab added this pull request to the merge queue Jul 18, 2024
Merged via the queue into linebender:main with commit 732cfa8 Jul 18, 2024
16 checks passed
@DJMcNab DJMcNab deleted the move-text-reference branch July 18, 2024 07:12
@RagibHasin RagibHasin mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJMcNab @waywardmonkeys