Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pre_load/ post_loadfor the views. #2213

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Implement pre_load/ post_loadfor the views. #2213

merged 7 commits into from
Jul 15, 2024

Commits on Jul 15, 2024

  1. Implement the pre_load / post_load for the views.

    @MathieuDutSik
    MathieuDutSik committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    041d6dc View commit details
    Browse the repository at this point in the history

  2. Remove the code that is no longer needed.

    @MathieuDutSik
    MathieuDutSik committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f25323c View commit details
    Browse the repository at this point in the history

  3. Further removals.

    @MathieuDutSik
    MathieuDutSik committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a0a40c7 View commit details
    Browse the repository at this point in the history

  4. Replace the from_bytes_opt with from_bytes_option.

    @MathieuDutSik
    MathieuDutSik committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9bae850 View commit details
    Browse the repository at this point in the history

  5. Introduce the "from_bytes_option_or_default".

    @MathieuDutSik
    MathieuDutSik committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    dbae1e6 View commit details
    Browse the repository at this point in the history

  6. Some corrections from the reviewing process 1.

    @MathieuDutSik
    MathieuDutSik committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    56cd95c View commit details
    Browse the repository at this point in the history

  7. Put explicit error if the input to the "post_load" is incorrect.

    @MathieuDutSik
    MathieuDutSik committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3b0fc9d View commit details
    Browse the repository at this point in the history