Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BlobId into enum #2231

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Make BlobId into enum #2231

merged 1 commit into from
Aug 1, 2024

Conversation

andresilva91
Copy link
Contributor

Motivation

As we replace different existing functionality with blobs, we'll need different blob types.

Proposal

Make BlobId into an enum

Test Plan

CI

@andresilva91 andresilva91 mentioned this pull request Jul 10, 2024
Merged
@andresilva91 Graphite App
Copy link
Contributor Author

andresilva91 commented Jul 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andresilva91 and the rest of your teammates on Graphite Graphite

@andresilva91 andresilva91 mentioned this pull request Jul 10, 2024
Merged
@andresilva91 andresilva91 force-pushed the 07-04-update_lagging_validators_on_blob_reads branch from 7983873 to 8fba8a5 Compare July 12, 2024 18:17
@andresilva91 andresilva91 force-pushed the 07-04-update_lagging_validators_on_blob_reads branch from 8fba8a5 to 51bbd3d Compare July 16, 2024 13:59
@andresilva91 andresilva91 marked this pull request as ready for review July 16, 2024 14:26
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 16, 2024

Graphite Automations

"Assign reviewers" took an action on this PR • (07/16/24)

6 reviewers were added to this PR based on Andre da Silva's automation.

@andresilva91 andresilva91 force-pushed the 07-04-update_lagging_validators_on_blob_reads branch from 51bbd3d to c2dfbb3 Compare July 16, 2024 14:55
afck
afck reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@afck afck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the PublishBlob operation now contain a CryptoHash rather than an arbitrary BlobId? We don't want to allow publishing other blob variants in the same way, after all.

linera-base/src/identifiers.rs Outdated Show resolved Hide resolved
linera-base/src/identifiers.rs Outdated Show resolved Hide resolved
linera-base/src/identifiers.rs Outdated Show resolved Hide resolved
linera-base/src/data_types.rs Outdated Show resolved Hide resolved
linera-core/src/local_node.rs Outdated Show resolved Hide resolved
@andresilva91 andresilva91 force-pushed the 07-04-update_lagging_validators_on_blob_reads branch from c2dfbb3 to c9dccd7 Compare July 16, 2024 15:48
@andresilva91 andresilva91 force-pushed the 07-04-update_lagging_validators_on_blob_reads branch 2 times, most recently from 1b3058c to ec045ca Compare July 19, 2024 18:48
@andresilva91 andresilva91 marked this pull request as draft July 19, 2024 18:52
@andresilva91 andresilva91 force-pushed the 07-04-update_lagging_validators_on_blob_reads branch from ec045ca to 6c76990 Compare July 19, 2024 19:09
@andresilva91 andresilva91 force-pushed the 07-04-update_lagging_validators_on_blob_reads branch 2 times, most recently from 2f9a0af to 631d466 Compare July 23, 2024 18:25
afck
afck reviewed Jul 29, 2024
View reviewed changes
linera-sdk/src/service/conversions_from_wit.rs Outdated Show resolved Hide resolved
linera-rpc/src/grpc/client.rs Outdated Show resolved Hide resolved
linera-base/src/data_types.rs Outdated Show resolved Hide resolved
linera-base/src/data_types.rs Outdated Show resolved Hide resolved
@andresilva91 andresilva91 force-pushed the 07-10-make_blobid_into_enum branch 2 times, most recently from c8c8569 to 3fc1888 Compare July 30, 2024 17:19
@andresilva91 andresilva91 changed the base branch from main to 07-30-make_hashedblob_s_fields_private July 30, 2024 17:19
@andresilva91 andresilva91 mentioned this pull request Jul 30, 2024
Merged
@andresilva91 andresilva91 marked this pull request as ready for review July 30, 2024 17:54
@andresilva91 andresilva91 requested review from afck and ma2bd July 30, 2024 17:54
@andresilva91 andresilva91 force-pushed the 07-30-make_hashedblob_s_fields_private branch 4 times, most recently from d2a89da to afa3383 Compare July 30, 2024 23:23
@andresilva91 andresilva91 force-pushed the 07-10-make_blobid_into_enum branch 2 times, most recently from 1006328 to 3a499b5 Compare July 31, 2024 00:30
afck
afck reviewed Jul 31, 2024
View reviewed changes
linera-base/src/data_types.rs Outdated Show resolved Hide resolved
linera-base/src/data_types.rs Show resolved Hide resolved
linera-base/src/data_types.rs Outdated Show resolved Hide resolved
@andresilva91 andresilva91 force-pushed the 07-30-make_hashedblob_s_fields_private branch from afa3383 to 98d3c44 Compare July 31, 2024 20:36
@andresilva91 andresilva91 force-pushed the 07-10-make_blobid_into_enum branch 2 times, most recently from 449b149 to 82ff7fd Compare July 31, 2024 21:09
Base automatically changed from 07-30-make_hashedblob_s_fields_private to main July 31, 2024 21:27
@andresilva91 andresilva91 requested a review from afck July 31, 2024 22:25
afck
afck approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@afck afck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers from my side.

linera-base/src/data_types.rs Show resolved Hide resolved
linera-base/src/data_types.rs Outdated Show resolved Hide resolved
linera-base/src/data_types.rs Outdated Show resolved Hide resolved
linera-core/src/local_node.rs Outdated Show resolved Hide resolved
@andresilva91 andresilva91 mentioned this pull request Aug 1, 2024
Merged
@andresilva91 andresilva91 merged commit bfde192 into main Aug 1, 2024
6 checks passed
@andresilva91 andresilva91 deleted the 07-10-make_blobid_into_enum branch August 1, 2024 17:24
Twey pushed a commit to Twey/linera-protocol that referenced this pull request Aug 6, 2024
@andresilva91 @Twey
Make BlobId into enum (linera-io#2231)
497106f 
As we replace different existing functionality with blobs, we'll need different blob types.

Make `BlobId` into an enum

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afck afck afck approved these changes

@jvff jvff Awaiting requested review from jvff

@Twey Twey Awaiting requested review from Twey

@christos-h christos-h Awaiting requested review from christos-h

@MathieuDutSik MathieuDutSik Awaiting requested review from MathieuDutSik

@ma2bd ma2bd Awaiting requested review from ma2bd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresilva91 @ma2bd @afck