Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolbar cache should be instance based only #262

Closed
sgratzl opened this issue Mar 17, 2020 · 0 comments · Fixed by #266
Closed

toolbar cache should be instance based only #262

sgratzl opened this issue Mar 17, 2020 · 0 comments · Fixed by #266
Assignees
@sgratzl
Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working
Projects
lineup

Comments

@sgratzl
Copy link
Member

sgratzl commented Mar 17, 2020

so far it is a lineup instance based one = kind of a side effect in the library.
@sgratzl sgratzl added type: bug Something isn't working lineup: v4 All issues related to LineUp v4 labels Mar 17, 2020
sgratzl added a commit that referenced this issue Mar 18, 2020
@sgratzl
avoid toolbar side effects
2bcccb1 
closes #262
@sgratzl sgratzl mentioned this issue Mar 18, 2020
Merged
4 tasks
@sgratzl sgratzl self-assigned this Mar 18, 2020
@sgratzl sgratzl linked a pull request Mar 20, 2020 that will close this issue
avoid toolbar side effects #266
Merged
4 tasks
@sgratzl sgratzl added this to Needs review in lineup Mar 20, 2020
@sgratzl sgratzl closed this as completed Mar 25, 2020
lineup automation moved this from Needs review to Done Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgratzl sgratzl

Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working
Projects
No open projects
lineup
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid toolbar side effects lineupjs/lineupjs
1 participant
@sgratzl