avoid toolbar side effects #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgratzl Is there a way to test it or what I should have a look it? |
|
to see an effect you would need a project where you create a new column type with a custom toolbar annotation. A running example where the LineUp.js library is loaded and using the new column type. Then when adding a new option to the toolbar and just hot reloading the custom class without loading lineupjs you should see that still the old toolbar is used, since the toolbar options were cached in the library instance of LineUp.js instead of the current LineUp instance. |
thinkh
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Thanks for the clarification.
An initial example would be https://codesandbox.io/s/empty-cherry-ynh2f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #262
prerequisites:
Summary
avoid side effects in the module for caching toolbar actions from columns. When developing toolbar addons one could experience caching issues