Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset colorMapping dialog for numerical column results in gray columns #283

Closed
thinkh opened this issue Apr 3, 2020 · 1 comment · Fixed by #289
Closed

Reset colorMapping dialog for numerical column results in gray columns #283

thinkh opened this issue Apr 3, 2020 · 1 comment · Fixed by #289
Assignees
@sgratzl
Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working

Comments

@thinkh
Copy link
Member

thinkh commented Apr 3, 2020

  • Release number or git hash: 9d9c5de
  • Web browser version and OS: Chrome 80

Steps to reproduce

  1. Open builder.html (something with a colored numerical column)
  2. Open the color mapping dialog
  3. Click on Reset

Observed behavior

lineup-reset-colormapping

Expected behavior

Reset to default values results in gray color instead of the original column color.
@thinkh thinkh added type: bug Something isn't working lineup: v4 All issues related to LineUp v4 labels Apr 3, 2020
sgratzl added a commit that referenced this issue Apr 6, 2020
@sgratzl
fix #283 reset color mapping
07cadb2
@sgratzl sgratzl mentioned this issue Apr 6, 2020
Merged
4 tasks
@sgratzl sgratzl linked a pull request Apr 6, 2020 that will close this issue
Fix color mapping reset + improve color mapping dialog #289
Merged
4 tasks
@thinkh
Copy link
Member Author

thinkh commented Apr 6, 2020

@sgratzl Please book your work for this issue on task M2 LineUp UI improvements.

@sgratzl sgratzl closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgratzl sgratzl

Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix color mapping reset + improve color mapping dialog lineupjs/lineupjs
2 participants
@sgratzl @thinkh