Fix color mapping reset + improve color mapping dialog #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkh
reviewed
Apr 7, 2020
There was a problem hiding this comment.
In general the reset works. I found another small bug while testing. If possible you can fix it in this PR. Otherwise I can open another issue.
- Select a diverging color scale
- Confirm the color mapping
- Open color dialog again
- No diverging color scale is selected
For solid color and sequential color it works as expected.
thinkh
approved these changes
Apr 7, 2020
thinkh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #283, #284
prerequisites:
Summary
proper reset of the color mapping dialog