Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item sorting influences group sorting, but should not #291

Closed
thinkh opened this issue Apr 7, 2020 · 3 comments · Fixed by #293
Closed

Item sorting influences group sorting, but should not #291

thinkh opened this issue Apr 7, 2020 · 3 comments · Fixed by #293
Assignees
Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working

Comments

@thinkh
Copy link
Member

thinkh commented Apr 7, 2020

  • Release number or git hash: 4.0.0-alpha.12
  • Web browser version and OS: independent

Steps to reproduce

  1. Open grouping.html
  2. Remove all sorting and grouping from hierarchies
  3. Sort number column in descending order
  4. Group by cat2
  5. Group by cat
  6. Collapse second level grouping
  7. Sort groups of cat in descending order
  8. Open first group
  9. Sort number column in ascending order
  10. Toggle the item sorting a few times

Observed behavior

lineup-item-sorting

Sorting the items (after the sorting groups) orders all groups differently and seems to follow the item sorting. Toggling the item sorting a few times afterwards is only sorting the items within the groups (which is the expected behavior). However, the group sorting is never restored.

Expected behavior

Item sorting should not influence the group sorting and only sort items within the groups. Group sorting should only arrange whole groups.

@thinkh thinkh added type: bug Something isn't working lineup: v4 All issues related to LineUp v4 labels Apr 7, 2020
@sgratzl
Copy link
Member

sgratzl commented Apr 7, 2020

can you create a cypress test, please

@thinkh
Copy link
Member Author

thinkh commented Apr 7, 2020

I'll try... 😄

thinkh added a commit that referenced this issue Apr 7, 2020
@thinkh
Copy link
Member Author

thinkh commented Apr 7, 2020

@sgratzl I created a cypress test in branch https://github.com/lineupjs/lineupjs/tree/thinkh/291_item-sorting-influence. Not sure about the file naming convention and the selectors itself. Please feel free to revise it.

sgratzl added a commit that referenced this issue Apr 7, 2020
@sgratzl sgratzl linked a pull request Apr 7, 2020 that will close this issue
4 tasks
@sgratzl sgratzl closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants