Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item sorting not influence group sorting #293

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Item sorting not influence group sorting #293

merged 3 commits into from
Apr 7, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Apr 7, 2020

closes #291

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

@sgratzl sgratzl requested a review from thinkh April 7, 2020 11:34
@sgratzl sgratzl linked an issue Apr 7, 2020 that may be closed by this pull request
Item sorting influences group sorting, but should not #291
Closed
thinkh
thinkh approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! It works well. 👍

@thinkh thinkh changed the title item sorting not influence group sorting Item sorting not influence group sorting Apr 7, 2020
@thinkh thinkh merged commit 7a9a470 into lineup-v4 Apr 7, 2020
@thinkh thinkh deleted the sgratzl/group_sort_influence branch April 7, 2020 12:40
@thinkh thinkh added the lineup: v4 All issues related to LineUp v4 label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
lineup: v4 All issues related to LineUp v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item sorting influences group sorting, but should not
2 participants
@sgratzl @thinkh