Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort categorical groups similar to sort values #273

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Sort categorical groups similar to sort values #273

merged 2 commits into from
Mar 25, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Mar 25, 2020

closes #161

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

unify categorical group sorting similar to value sorting:

image

@sgratzl sgratzl requested a review from thinkh March 25, 2020 13:55
@sgratzl sgratzl linked an issue Mar 25, 2020 that may be closed by this pull request
Broken "sort groups by..." for multiple sort criteria #161
Closed
@thinkh thinkh changed the title closes #161 sort groups similar to sort values Sort categorical groups similar to sort values Mar 25, 2020
@thinkh thinkh added lineup: v4 All issues related to LineUp v4 release: minor PR merge results in a new minor version type: feature New feature or request labels Mar 25, 2020
thinkh
thinkh approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks better.

I have to admit that I was slighty confused when I had grouped by cat and cat2 and sort groups by cat2 ascending only.

grafik

I was expecting the that it looks like this (sorting cat asc, cat2 asc):

grafik

However, after thinking about it I realized, that the group hierarchy and sort hierarchy are applied independently.

@thinkh thinkh merged commit 33c3fac into lineup-v4 Mar 25, 2020
@thinkh thinkh deleted the sgratzl/catsort branch March 25, 2020 14:20
@thinkh thinkh mentioned this pull request Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
lineup: v4 All issues related to LineUp v4 release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken "sort groups by..." for multiple sort criteria
2 participants
@sgratzl @thinkh