Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize filter dialogs #296

Merged
merged 5 commits into from
Apr 16, 2020
Merged

Optimize filter dialogs #296

merged 5 commits into from
Apr 16, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Apr 8, 2020

closes #295 based on #292

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

@sgratzl sgratzl requested a review from thinkh April 8, 2020 11:55
@sgratzl sgratzl linked an issue Apr 8, 2020 that may be closed by this pull request
Inconsistent edit filter value dialog (shift click on min/max handles) #295
Closed
@mstreit
Copy link
Contributor

mstreit commented Apr 8, 2020

@sgratzl, can you provide a screenshot please?

@sgratzl
Copy link
Member Author

sgratzl commented Apr 8, 2020

there is no visual change, just a unification as described in #295

@mstreit
Copy link
Contributor

mstreit commented Apr 8, 2020

OK, sry.

@thinkh thinkh changed the title optimize filter dialogs Optimize filter dialogs Apr 10, 2020
@thinkh thinkh added the lineup: v4 All issues related to LineUp v4 label Apr 10, 2020
thinkh
thinkh approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Waiting for PR #292 to be merged first.

@sgratzl sgratzl mentioned this pull request Apr 14, 2020
Merged
4 tasks
@thinkh thinkh merged commit e11ed21 into lineup-v4 Apr 16, 2020
@thinkh thinkh deleted the sgratzl/filter_tuning branch April 16, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
lineup: v4 All issues related to LineUp v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent edit filter value dialog (shift click on min/max handles)
3 participants
@sgratzl @mstreit @thinkh