-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use interactive date summary histogram for filtering #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change. While testing the filter I found the following bugs.
Filter icon still highlighted after clicking reset
- Open date filter dialog
- Select a date range
- Click on reset
Observed behavior
The filter icon is still orange.
Expected result
The filter icon should not be highlighted after click on reset.
Edit min/max date filter
- Open date filter dialog
- Double click on min/max handler
- Change date in input field
- Press Enter
Observed behavior
The Enter key does not work and clicking outside is equal to cancel the change. Hence, it is currently impossible to change the date using the edit date dialog.
Expected behavior
Best case: Enter key is working to confirm the change (which would be conform with the number filter dialog)
Alternative: Add apply/cancel/reset button to this dialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected! 👍
based on #296
closes #299
prerequisites:
Summary