Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use interactive date summary histogram for filtering #303

Merged
merged 7 commits into from
Apr 16, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Apr 14, 2020

based on #296

closes #299

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

image

@sgratzl sgratzl requested a review from thinkh April 14, 2020 09:16
@sgratzl sgratzl linked an issue Apr 14, 2020 that may be closed by this pull request
@thinkh thinkh changed the title use interactive date summary histogram for filtering Use interactive date summary histogram for filtering Apr 14, 2020
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. While testing the filter I found the following bugs.

Filter icon still highlighted after clicking reset

  1. Open date filter dialog
  2. Select a date range
  3. Click on reset

Observed behavior

The filter icon is still orange.

lineup-reset-date-filter-dialog

Expected result

The filter icon should not be highlighted after click on reset.

Edit min/max date filter

  1. Open date filter dialog
  2. Double click on min/max handler
  3. Change date in input field
  4. Press Enter

Observed behavior

lineup-edit-date-filter-dialog

The Enter key does not work and clicking outside is equal to cancel the change. Hence, it is currently impossible to change the date using the edit date dialog.

Expected behavior

Best case: Enter key is working to confirm the change (which would be conform with the number filter dialog)
Alternative: Add apply/cancel/reset button to this dialog

@sgratzl sgratzl requested a review from thinkh April 15, 2020 08:45
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 👍

@thinkh thinkh merged commit 9b272d4 into lineup-v4 Apr 16, 2020
@thinkh thinkh deleted the sgratzl/datefilter branch April 16, 2020 08:50
@thinkh thinkh added the lineup: v4 All issues related to LineUp v4 label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lineup: v4 All issues related to LineUp v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify date filter dialog
2 participants