Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and store yarn in repo #477

Merged
merged 6 commits into from
Aug 24, 2021
Merged

update dependencies and store yarn in repo #477

merged 6 commits into from
Aug 24, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 24, 2021

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

also fixes the release drafter for alpha-releases. adds yarn to the repo as suggested by https://yarnpkg.com/getting-started/qa/#which-files-should-be-gitignored

@sgratzl sgratzl added the chore label Aug 24, 2021
@sgratzl sgratzl requested a review from thinkh August 24, 2021 12:08
@sgratzl sgratzl self-assigned this Aug 24, 2021
@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for lineupjs ready!

🔨 Explore the source changes: 5ace66a

🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/612505393eacea3ee64ad313

😎 Browse the preview: https://deploy-preview-477--lineupjs.netlify.app/

@sgratzl sgratzl mentioned this pull request Aug 24, 2021
3 tasks
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the following tests successfully:

  • Checkout branch
  • Follow install instructions
  • yarn run build:dev
  • yarn start

LineUp is still compiling and working.

@thinkh
Copy link
Member

thinkh commented Aug 24, 2021

@sgratzl The deploy preview via netlify is really helpful and nice. Thanks for the integration! 👍

@sgratzl sgratzl merged commit 305a7b9 into develop Aug 24, 2021
@sgratzl sgratzl deleted the sgratzl/deps branch August 24, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants