-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tick vis, adjust lightness of bars vs ticks/dots #514
Conversation
closes #495
✔️ Deploy Preview for lineupjs ready! 🔨 Explore the source changes: 8f2093f 🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/61cb149a63e42600077d45a7 😎 Browse the preview: https://deploy-preview-514--lineupjs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the specification it looks fine. However, the ticks that are at the left or right border of the cell are cut-off and look thinner. Does it make sense to shift the tick slightly so that it is always completely visible?
@alexsb Please have a look at the netlify preview and answer the following questions:
- Does the visualization title "Tick" makes sense for you?
- General question: when would you use the tick visualization? To me the (default) bar visualization works much better:
Ticks
Bars
Second @thinkh on the small ticks on the side - I wouldn't shift a tick though, but maybe make the render area a bit bigger (or the scale's region) so that this doesn't happen. Re name: I think "tick" is good. Vega also uses that term: https://vega.github.io/vega-lite/docs/tick.html |
I've created a related issue in #524 related to labeling for selected columns. |
Also see #525 for a related issue regarding appearance/darkness |
+ thinner + lighter missing marks
changes:
|
closes #488
That looks great! |
Michael, this is ready to review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
closes #495
prerequisites:
Summary
also add a categorical tick version (part of #488 )