Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tick vis, adjust lightness of bars vs ticks/dots #514

Merged
merged 11 commits into from
Jan 26, 2022
Merged

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Nov 24, 2021

closes #495

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

image

also add a categorical tick version (part of #488 )

image

@sgratzl sgratzl added the type: feature New feature or request label Nov 24, 2021
@sgratzl sgratzl requested a review from thinkh November 24, 2021 20:58
@sgratzl sgratzl self-assigned this Nov 24, 2021
@netlify
Copy link

netlify bot commented Nov 24, 2021

✔️ Deploy Preview for lineupjs ready!

🔨 Explore the source changes: 8f2093f

🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/61cb149a63e42600077d45a7

😎 Browse the preview: https://deploy-preview-514--lineupjs.netlify.app

Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the specification it looks fine. However, the ticks that are at the left or right border of the cell are cut-off and look thinner. Does it make sense to shift the tick slightly so that it is always completely visible?

grafik

@alexsb Please have a look at the netlify preview and answer the following questions:

  1. Does the visualization title "Tick" makes sense for you?
  2. General question: when would you use the tick visualization? To me the (default) bar visualization works much better:

Ticks

grafik

Bars

grafik

@alexsb
Copy link
Contributor

alexsb commented Dec 13, 2021

Second @thinkh on the small ticks on the side - I wouldn't shift a tick though, but maybe make the render area a bit bigger (or the scale's region) so that this doesn't happen.

Re name: I think "tick" is good. Vega also uses that term: https://vega.github.io/vega-lite/docs/tick.html

@alexsb
Copy link
Contributor

alexsb commented Dec 13, 2021

I've created a related issue in #524 related to labeling for selected columns.

@alexsb
Copy link
Contributor

alexsb commented Dec 13, 2021

Also see #525 for a related issue regarding appearance/darkness

@sgratzl
Copy link
Member Author

sgratzl commented Dec 23, 2021

changes:

image

@sgratzl sgratzl changed the title add tick vis add tick vis, adjust lightness of bars vs ticks/dots Dec 23, 2021
@sgratzl sgratzl mentioned this pull request Dec 23, 2021
3 tasks
@alexsb
Copy link
Contributor

alexsb commented Dec 24, 2021

Nice!

Here are two examples:

Screen Shot 2021-12-24 at 10 49 50 AM

image

I'd say the ticks appear a bit darker than the dots, and the bars appear a bit lighter than the dots. So maybe try decreasing lightness for the bars and increasing lightness for the ticks a bit.

@sgratzl
Copy link
Member Author

sgratzl commented Dec 28, 2021

take a look:
image
image

@alexsb
Copy link
Contributor

alexsb commented Jan 4, 2022

That looks great!

@alexsb
Copy link
Contributor

alexsb commented Jan 13, 2022

Michael, this is ready to review and merge.

@sgratzl sgratzl linked an issue Jan 21, 2022 that may be closed by this pull request
Copy link
Contributor

@puehringer puehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sgratzl sgratzl merged commit 45f6449 into develop Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust darkness for various elements
4 participants