-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch LineUp dependency from next
to version number
#604
Conversation
Now possible since we switched from `node-sass` to `sass` (Dart Sass) phovea/generator-phovea#439
next
to version number #603 next
to version number
With PR lineupjs/lineupjs#480 text sanitation was introduced. The searchbox' `formatItem()` has changed. This commit changes our format function accordingly. It also converts the `…` to the unicode pendant.
I still found a bug while testing. With PR lineupjs/lineupjs#480 text sanitation was introduced. The searchbox' Before After |
…warning LineUp: Style data mapping dialog warning
@anita-steiner Because lineupjs now supports github installs again (as seen in this build), should we use github installs again or should we use actual version numbers? |
…603_update-lineupjs-dependency
Has this been reported already? Resizing the columns does not work in ordino Error message: Edit: Created an issue lineupjs/lineupjs#545 |
TODO @thinkh Enable |
@puehringer I've enabled the scheduled task executor. Please test it in some apps. |
@thinkh In general, the scheduled task executor works fine for me, except that the loading overlay in the columns is rather annoying. I would prefer those to only show initially, but not when "recomputing". An alternative would be a see-through overlay instead of showing only the loading indicator. |
@puehringer Yes, the flickering is a bit disruptive. From the UX point, I would not remove the loading indicator, since something is still going on the old values are invalid. I like the idea of the half transparent loading indicator that overlays the old state. I think that needs to be changed in LineUp itself, right? |
Closes #603
Summary
Switch lineupjs dependency from
next
to version number or github branch (see explanation in issue Switch LineUp dependency fromnext
to version number #603)With PR Switch from
node-sass
to Dart Sass (sass
) phovea/generator-phovea#439 we switched fromnode-sass
tosass
(Dart Sass) and we can now import LineUp Sass files again and also modify the Sass variables.Includes many new LineUp features:
null
orNaN
for min/max in numerical columns, orundefined
for categorical columns for this to take effect. This will require some changes @dvdanielamoitzi @dg-datavisyn (i.e. applications where this is done right now --> can be removed), @oltionchampari (i.e. scores, because the hacky infering is removed with this PR --> scores need to remove a proper min/max for example to infer it automatically).