Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch LineUp dependency from next to version number #604

Merged
merged 27 commits into from
May 12, 2022

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Dec 29, 2021

Closes #603

Summary

@thinkh thinkh added the dependencies Pull requests that update a dependency file label Dec 29, 2021
@thinkh thinkh requested review from a user and puehringer December 29, 2021 23:23
@thinkh thinkh linked an issue Dec 29, 2021 that may be closed by this pull request
@thinkh thinkh changed the title Switch LineUp dependency from next to version number #603 Switch LineUp dependency from next to version number Dec 29, 2021
With PR lineupjs/lineupjs#480 text sanitation was introduced.
The searchbox' `formatItem()` has changed.
This commit changes our format function accordingly.
It also converts the `…` to the unicode pendant.
@thinkh
Copy link
Member Author

thinkh commented Jan 7, 2022

I still found a bug while testing. With PR lineupjs/lineupjs#480 text sanitation was introduced. The searchbox' formatItem() has changed. The last commit changes our format function accordingly. It also converts the … to the unicode pendant.

Before

grafik

After

grafik

@puehringer
Copy link
Contributor

@anita-steiner Because lineupjs now supports github installs again (as seen in this build), should we use github installs again or should we use actual version numbers?
I think version numbers are to be preferred (given a fastish lineup release cycle), as a) lineup will not easily break our workspaces, and b) releases are easier as we don't need to change any versions.

@puehringer puehringer requested review from dvdanielamoitzi and removed request for a user February 11, 2022 10:04
@oltionchampari
Copy link
Contributor

oltionchampari commented Feb 16, 2022

Has this been reported already? Resizing the columns does not work in ordino

grafik2

Error message:

grafik

Edit: Created an issue lineupjs/lineupjs#545

@thinkh
Copy link
Member Author

thinkh commented Mar 17, 2022

TODO @thinkh Enable ScheduledRenderingTask in LineUp (after evaluation in https://github.com/datavisyn/reprovisyn/issues/186).

@thinkh
Copy link
Member Author

thinkh commented Mar 18, 2022

@puehringer I've enabled the scheduled task executor. Please test it in some apps.

@puehringer
Copy link
Contributor

@thinkh In general, the scheduled task executor works fine for me, except that the loading overlay in the columns is rather annoying. I would prefer those to only show initially, but not when "recomputing". An alternative would be a see-through overlay instead of showing only the loading indicator.

Lineup_Async

@thinkh
Copy link
Member Author

thinkh commented Mar 22, 2022

@puehringer Yes, the flickering is a bit disruptive. From the UX point, I would not remove the loading indicator, since something is still going on the old values are invalid. I like the idea of the half transparent loading indicator that overlays the old state. I think that needs to be changed in LineUp itself, right?

@thinkh thinkh merged commit d36b9dd into develop May 12, 2022
@thinkh thinkh deleted the thinkh/603_update-lineupjs-dependency branch May 12, 2022 12:07
@dvvanessastoiber dvvanessastoiber mentioned this pull request Jun 15, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch LineUp dependency from next to version number
4 participants