Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support both selection and text select #515

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Support both selection and text select #515

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a01e36d
feat: try to support both selection and text select
sgratzl Nov 24, 2021
ce06e8e
Merge remote-tracking branch 'origin/develop' into sgratzl/selection_…
sgratzl Aug 9, 2022
f4ffb77
fix: some export syntax to fix yarn start
sgratzl Aug 10, 2022
73ffb16
fix: limit vertical dragging to selection column only
sgratzl Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions src/ui/SelectionManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export declare function selectRange(from: number, to: number, additional: boolea
export default class SelectionManager extends AEventDispatcher {
static readonly EVENT_SELECT_RANGE = 'selectRange';
private static readonly MIN_DISTANCE = 10;
private static readonly MAX_X_DISTANCE = 30;

private readonly hr: HTMLHRElement;

Expand All @@ -51,21 +52,28 @@ export default class SelectionManager extends AEventDispatcher {
this.body.removeEventListener('mouseup', mouseUp);
this.body.removeEventListener('mouseleave', mouseUp);

if (!this.start) {
this.body.classList.remove(cssClass('selection-active'));
this.hr.classList.remove(cssClass('selection-active'));
const start = this.start;
this.start = null;

if (!start) {
return;
}

const valid = Math.abs(start.x - evt.clientX) < SelectionManager.MAX_X_DISTANCE;
if (!valid) {
return;
}

const row = engineCssClass('tr');
const startNode = this.start.node.classList.contains(row)
? this.start.node
: this.start.node.closest<HTMLElement>(`.${row}`);

const startNode = start.node.classList.contains(row) ? start.node : start.node.closest<HTMLElement>(`.${row}`);

// somehow on firefox the mouseUp will be triggered on the original node
// thus search the node explicitly
const end = this.body.ownerDocument!.elementFromPoint(evt.clientX, evt.clientY) as HTMLElement;
const endNode = end.classList.contains(row) ? end : end.closest<HTMLElement>(`.${row}`);
this.start = null;

this.body.classList.remove(cssClass('selection-active'));
this.hr.classList.remove(cssClass('selection-active'));

this.select(evt.ctrlKey, startNode, endNode);
};
Expand All @@ -76,7 +84,6 @@ export default class SelectionManager extends AEventDispatcher {
const r = root.getBoundingClientRect();
this.start = { x: evt.clientX, y: evt.clientY, xShift: r.left, yShift: r.top, node: evt.target as HTMLElement };

this.body.classList.add(cssClass('selection-active'));
body.addEventListener('mousemove', mouseMove, {
passive: true,
});
Expand Down Expand Up @@ -122,10 +129,15 @@ export default class SelectionManager extends AEventDispatcher {

private showHint(end: MouseEvent) {
const start = this.start!;
const sx = start.x;
const sy = start.y;
const ex = end.clientX;
const ey = end.clientY;

const visible = Math.abs(sy - ey) > SelectionManager.MIN_DISTANCE;
const visible =
Math.abs(sy - ey) > SelectionManager.MIN_DISTANCE && Math.abs(sx - ex) < SelectionManager.MAX_X_DISTANCE;

this.body.classList.toggle(cssClass('selection-active'), visible);
this.hr.classList.toggle(cssClass('selection-active'), visible);
this.hr.style.transform = `translate(${start.x - start.xShift}px,${sy - start.yShift}px)scale(1,${Math.abs(
ey - sy
Expand Down