-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve dropzones #534
improve dropzones #534
Conversation
and remove extra drop effects closes #504
✔️ Deploy Preview for lineupjs ready! 🔨 Explore the source changes: 69f9b63 🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/620519348a27880008779c62 😎 Browse the preview: https://deploy-preview-534--lineupjs.netlify.app |
Awesome, thanks! Two comments though:
|
the header image is rendered by the browser not by me, thus not sure whether I can manipulate it on the fly. Even if it would be to manipulate the original header of the column being dragged within the LineUp header row. Thus, it might be more confusing that helpful. |
OK, I don't think it's critical, so good to merge as far as I'm concerned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me now as expected, I think this PR can be merged as of now 🎉
closes #504
prerequisites:
Summary