-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selection indicator #535
selection indicator #535
Conversation
✔️ Deploy Preview for lineupjs ready! 🔨 Explore the source changes: c461369 🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/61dc2a798930d40008f85887 😎 Browse the preview: https://deploy-preview-535--lineupjs.netlify.app |
@alexsb take a look again, it should be better but there are limits since I have to change the position of the bar each time you scroll |
It's still pretty jittery? Not sure what a good solution would be. Just as a sanity check: there's no simple solution, like a css If not, then maybe fade out while we're scrolling? [though that defeats the purpose a bit] |
This is perfect! Thank You! |
@sgratzl Thanks, I briefly tested this PR using https://deploy-preview-535--lineupjs.netlify.app/big.html and found an issue:
I suppose it should update this selection hint with order changes. |
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉
closes #528
prerequisites:
Summary
add selection indicator on the right