Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection indicator #535

Merged
merged 5 commits into from
Jan 18, 2022
Merged

selection indicator #535

merged 5 commits into from
Jan 18, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Dec 28, 2021

closes #528

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

add selection indicator on the right

image

@sgratzl sgratzl added the type: feature New feature or request label Dec 28, 2021
@sgratzl sgratzl requested a review from thinkh December 28, 2021 17:46
@sgratzl sgratzl self-assigned this Dec 28, 2021
@netlify
Copy link

netlify bot commented Dec 28, 2021

✔️ Deploy Preview for lineupjs ready!

🔨 Explore the source changes: c461369

🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/61dc2a798930d40008f85887

😎 Browse the preview: https://deploy-preview-535--lineupjs.netlify.app

@sgratzl sgratzl linked an issue Dec 28, 2021 that may be closed by this pull request
@thinkh thinkh requested a review from alexsb December 29, 2021 22:54
@sgratzl
Copy link
Member Author

sgratzl commented Jan 4, 2022

@alexsb take a look again, it should be better but there are limits since I have to change the position of the bar each time you scroll

@alexsb
Copy link
Contributor

alexsb commented Jan 4, 2022

It's still pretty jittery?

Not sure what a good solution would be. Just as a sanity check: there's no simple solution, like a css position: absolute here? Or moving the bar into a side-bar similar to the histograms/column configs on the right?

If not, then maybe fade out while we're scrolling? [though that defeats the purpose a bit]

@alexsb
Copy link
Contributor

alexsb commented Jan 4, 2022

This is perfect! Thank You!

@puehringer
Copy link
Contributor

@sgratzl Thanks, I briefly tested this PR using https://deploy-preview-535--lineupjs.netlify.app/big.html and found an issue:

  1. Select some range in the ranking (the selection hint is correct)
  2. Sort by some column (in this case Number2)
  3. The selection hint does not update and stays on the "old" position
    Selection_Test

I suppose it should update this selection hint with order changes.

@sgratzl
Copy link
Member Author

sgratzl commented Jan 10, 2022

I suppose it should update this selection hint with order changes.

fixed

@alexsb alexsb requested review from puehringer and removed request for thinkh January 13, 2022 12:21
Copy link
Contributor

@puehringer puehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@sgratzl sgratzl merged commit ae97230 into develop Jan 18, 2022
@sgratzl sgratzl deleted the sgratzl/selectionindicator branch January 18, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show off-screen visualization for selected items.
3 participants