Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible fix for npm install #541

Merged
merged 3 commits into from
Jan 28, 2022
Merged

possible fix for npm install #541

merged 3 commits into from
Jan 28, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Jan 27, 2022

closes #539

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

use npm run since yarn doesn't warn anymore + update dependency such that npm has no problem with them anymore.

However, npm/cli#1865 (comment) remains and I don't now how to fix it in npm 7.

@sgratzl sgratzl added the chore label Jan 27, 2022
@sgratzl sgratzl self-assigned this Jan 27, 2022
@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for lineupjs ready!

🔨 Explore the source changes: 5b22009

🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/61f1fe4463355b0008d8d1fc

😎 Browse the preview: https://deploy-preview-541--lineupjs.netlify.app

@sgratzl sgratzl changed the base branch from main to develop January 27, 2022 02:07
Copy link
Contributor

@puehringer puehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me with npm 6.14.15, including the prepare (i.e. build during installs for github installs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install of github branch via npm does not work
2 participants