New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-93507 Poshi Script SF: Braces that are in the wrong line #76

Closed

ling-alan-huang wants to merge 13 commits into master from pull-request-3588-LPS-93507_new

Owner

ling-alan-huang commented Jun 19, 2019

No description provided.

ling-alan-huang and others added 13 commits

June 19, 2019 08:17


          LPS-84119 Ignore this rule for multiline strings and comments

468cdd7


          LPS-84119 Add testcases

2adbf49


          LPS-93507 Add rules for control flow statements

4abf20d


          LPS-93507 Add 'task' keyword for Poshi Script

4f767ec


          LPS-93507 Enforce one space between ) and {

3cd22f3


          LPS-93507 Remove redundant logic, since it is already done in other c…

41f3f8e

…heck


          LPS-93507 Add testcases

cc6e0dc


          LPS-93507 Consolidate logic

ab498e2


          LPS-93507 Add the rule for if-else statement

d398701


          LPS-93507 Add testcases

a05d561


          LPS-93507 SF

8017a07


          LPS-93507 Change testcases to make sure we cannot retrieve multiLineP…

d522ffe

…ositions only once


          LPS-93507 Auto SF

a0ffa91

Collaborator

liferay-continuous-integration commented Jun 19, 2019

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

Owner Author

ling-alan-huang commented Jun 19, 2019

ci:test:sf

Owner Author

ling-alan-huang commented Jun 19, 2019

ci:test:relevant

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels

Collaborator

liferay-continuous-integration commented Jun 19, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 15 minutes 9 seconds 505 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fb8aea119067138588a4e3263dff33f3a9e5950f

Sender Branch:

Branch Name: pull-request-3588-LPS-93507_new
Branch GIT ID: a0ffa91d2c070c9f4732b47783d43268fc525954

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration added the ci:test:relevant - pending label

ling-alan-huang mentioned this pull request

LPS-93507 Poshi Script SF: Braces that are in the wrong line hhuijser/liferay-portal#3591

Closed

Owner Author

ling-alan-huang commented Jun 19, 2019

Removed Auto SF and sent to Hugo for review.
hhuijser#3591

ling-alan-huang closed this

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels

Collaborator

liferay-continuous-integration commented Jun 19, 2019

❌ ci:test:relevant - 7 out of 89 jobs passed in 1 hour 22 minutes 33 seconds 43 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5944d4af74ce7880bb8c4f3c1d70960ad01a2aeb

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 1f6852665e83c6960fa70c54f60a4f7307e11451

7 out of 89 jobs PASSED

82 Failed Jobs:

7 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #305193

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #299901

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #302941

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #59274

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/10

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #305190

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment