Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there an exception thrown on FileDownloadListener#blockComplete, callback error instead completed. #305

Closed
Jacksgong opened this issue Sep 6, 2016 · 0 comments
Closed

If there an exception thrown on FileDownloadListener#blockComplete, callback error instead completed. #305

Jacksgong opened this issue Sep 6, 2016 · 0 comments
Labels
enhancement
Milestone
1.1.0

Comments

@Jacksgong
Copy link
Collaborator

Jacksgong commented Sep 6, 2016 •
edited

In the current version, if you occur an exception on FileDownloadListener#blockCompleted, you must handle it by yourself, It does not so make sense consider FileDownloadListener has error method, but we don't call back it.

In the next version, FileDownloader will handle any Throwable which thrown on FileDownloadListener#blockComplete method and callback FileDownloadListener#error method instead of still call back FileDownloadListener#completed.
@Jacksgong Jacksgong added this to the 1.1.0 milestone Sep 6, 2016
Jacksgong added a commit that referenced this issue Sep 13, 2016
@Jacksgong
dcos(art): replace the callback flow graph of FileDownloadListener, a…
81043ff 
…dd the 'error' method callback after occuring an exception in 'blockComplete'

Refs #305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@Jacksgong