Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: po-gettext format issues with CLI #1073

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

nakkamarra
Copy link
Contributor

I noticed two issues with the po-gettext format option:

  1. The disableSelectWarning flag is not part of the CatalogFormatOptions type, and so it is reported as being invalid by the CLI:

Screen Shot 2021-05-25 at 1 32 13 PM

  1. The po-gettext format does not properly support the use of lineNumbers format option that the standard po format option supports.

@vercel
Copy link

vercel bot commented May 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/3jS5ci3Mack18tZvmCPhe9ciEvrV
✅ Preview: https://js-lingui-git-fork-nakkamarra-fix-po-gettext-format-lingui-js.vercel.app

@nakkamarra nakkamarra changed the title Fix po gettext format fix: po-gettext format issues with CLI May 25, 2021
@nakkamarra
Copy link
Contributor Author

@semoal hey, can I get a quick review on this when you have the chance? Thanks.

@nakkamarra
Copy link
Contributor Author

@semoal It looks like @iStefo authored the feature, so perhaps he would be able to give a quick review if you are too busy?

@semoal
Copy link
Contributor

semoal commented Jun 4, 2021

Hello Nick, sorry for the delay, had been busy lately with work and Rematch's book.
I'll take a review to everything this weekend and on Tuesday we'll release a version =)

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #1073 (2a80e3b) into main (9990eba) will decrease coverage by 0.16%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
- Coverage   83.20%   83.04%   -0.17%     
==========================================
  Files          53       53              
  Lines        1620     1622       +2     
  Branches      441      442       +1     
==========================================
- Hits         1348     1347       -1     
- Misses        159      160       +1     
- Partials      113      115       +2     
Impacted Files Coverage Δ
packages/cli/src/api/formats/index.ts 60.00% <ø> (ø)
packages/cli/src/api/formats/po-gettext.ts 83.60% <25.00%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9990eba...2a80e3b. Read the comment docs.

@semoal semoal merged commit a529aca into lingui:main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants