Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n for non-react messages #12

Merged
merged 34 commits into from
Feb 12, 2017
Merged

i18n for non-react messages #12

merged 34 commits into from
Feb 12, 2017

Conversation

tricoder42
Copy link
Contributor

  • babel-plugin-lingui-transform-js - transform i18n syntax into icu message format
  • babel-plugin-lingui-extract-messages - collect messages from i18n.t method calls
  • lingui-i18n - no-op methods, which are replaced by correct function calls in babel
  • example-usecase - update example and add usecases with string-only translations

Closes #10

@tricoder42
feat: Add babel-plugin-lingui-transform-i18n
da7c553 
affects: babel-plugin-lingui-transform-js
@tricoder42
feat: Transform plural and select calls
c73efef 
affects: babel-plugin-lingui-transform-js
@tricoder42
feat: Transform ordinal format
2755aa4 
affects: babel-plugin-lingui-transform-js
@tricoder42
feat: Extract messages from i18n method calls
d6ef2a8 
affects: babel-plugin-lingui-extract-messages
@tricoder42
test: Test that extract plugin doesn't require JSX enabled
e282e1b 
affects: babel-plugin-lingui-extract-messages
@tricoder42
docs(readme): Add usage and installation instruction
dbc2665 
affects: babel-plugin-lingui-transform-js
@tricoder42
docs(readme): Update instructions
649f751 
affects: babel-plugin-lingui-transform-react
@tricoder42
chore: Add .npmignore files
13f7e79 
affects: babel-plugin-lingui-transform-js, babel-plugin-lingui-transform-react
@tricoder42
feat: Replace InjectI18n with configurable WithI18n
f383350 
affects: lingui-react
@tricoder42
feat: Add types and make i18n noop when no catalog is loaded
801c00b 
affects: lingui-i18n
@tricoder42
chore: Add eslint and flow type linters
7ab4a64
@tricoder42
style: Fix linter errors
6538664 
affects: babel-plugin-lingui-extract-messages, babel-plugin-lingui-transform-js, babel-plugin-lingui-transform-react, example-usecase, lingui-cli, lingui-conf, lingui-i18n, lingui-react
@tricoder42
fix: Replace 'others' with correct 'other' (plural form)
b4203aa 
affects: babel-plugin-lingui-extract-messages, babel-plugin-lingui-transform-js, babel-plugin-lingui-transform-react, lingui-i18n
@tricoder42
test: Add test for temporary change of language
bf4110f 
affects: lingui-i18n
@tricoder42
fix: Merge catalogs on load
6f0a315 
affects: lingui-i18n
@tricoder42
Replace messageformat with lingui-i18n
fdca8b7
@tricoder42
fix: Fix flow type warnings and related bugs
b78b055 
affects: lingui-i18n, lingui-react
@tricoder42
chore: Copy src files as flow definition files to lib dir
0277231 
affects: lingui-i18n
@tricoder42
test: Flow fixes after module is finally resolved
13a8d41 
affects: lingui-react
@tricoder42
feat: Export flow types with package
b65006c 
affects: lingui-react
@tricoder42
fix: Fix type for WithI18n HOC
4889a28 
affects: lingui-react
@tricoder42
test: Fix error snapshot testing due to incorrent paths on ci env
8bec0a0 
affects: babel-plugin-lingui-transform-js
@tricoder42
test: Make snapshot testing great again
ee4e4b0 
affects: babel-plugin-lingui-transform-js
@tricoder42
chore: Add import eslint plugin
c52045d
@tricoder42
chore: Add lint command
a317a7e
@tricoder42
refactor: Split usecase to view and container
880e172
@tricoder42
test: Update obsolete snapshot
dfd68d9 
affects: example-usecase
@tricoder42
fix: Fix js method transformation in react expression containers
a385110 
affects: babel-plugin-lingui-transform-js
@tricoder42
chore: Ignore all node_modules in jest transformation
3d70042
@tricoder42
test: Add usecase with i18n using function call
745287c
@tricoder42
fix: Return null when line number isn't available
19960de 
affects: babel-plugin-lingui-extract-messages

i18n message calls doesn't have line number info for some reason.
When expression is bound to variable, it works:

    // ok
    const a = i18n.t`Hello World`

but when expression is standalone, it doesn't work:

    // line number is missing
    i18n.t`Hello World`

This is problem in JSXExpressionContainers.
@tricoder42
fix: Copy source location manually
06fc527 
affects: babel-plugin-lingui-extract-messages, babel-plugin-lingui-transform-js

A bit hackish fix, but works.
@codecov
Copy link

codecov bot commented Feb 12, 2017

Codecov Report

Merging #12 into master will increase coverage by 0.05%.
The diff coverage is 99.36%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   99.62%   99.68%   +0.05%     
==========================================
  Files          14       17       +3     
  Lines         268      313      +45     
==========================================
+ Hits          267      312      +45     
  Misses          1        1
Impacted Files Coverage Δ
packages/lingui-react/src/Select.js 100% <ø> (ø) ✅
packages/example-usecase/src/Usecase.js 100% <100%> (ø) ✅
packages/lingui-i18n/src/i18n.js 100% <100%> (ø) ✅
packages/lingui-react/src/Trans.js 100% <100%> (ø) ✅
packages/lingui-i18n/src/t.js 100% <100%> (ø) ✅
packages/lingui-i18n/src/select.js 100% <100%> (ø) ✅
...s/babel-plugin-lingui-transform-react/src/index.js 100% <100%> (ø) ✅
.../babel-plugin-lingui-extract-messages/src/index.js 100% <100%> (ø) ✅
...ages/babel-plugin-lingui-transform-js/src/index.js 100% <100%> (ø)
packages/lingui-react/src/Plural.js 100% <100%> (ø) ✅
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503608c...06fc527. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 12, 2017 •
edited

Codecov Report

Merging #12 into master will increase coverage by 0.05%.
The diff coverage is 99.36%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   99.62%   99.68%   +0.05%     
==========================================
  Files          14       17       +3     
  Lines         268      313      +45     
==========================================
+ Hits          267      312      +45     
  Misses          1        1
Impacted Files Coverage Δ
packages/lingui-react/src/Select.js 100% <ø> (ø) ✅
packages/example-usecase/src/Usecase.js 100% <100%> (ø) ✅
packages/lingui-i18n/src/i18n.js 100% <100%> (ø) ✅
packages/lingui-react/src/Trans.js 100% <100%> (ø) ✅
packages/lingui-i18n/src/t.js 100% <100%> (ø) ✅
packages/lingui-i18n/src/select.js 100% <100%> (ø) ✅
...s/babel-plugin-lingui-transform-react/src/index.js 100% <100%> (ø) ✅
.../babel-plugin-lingui-extract-messages/src/index.js 100% <100%> (ø) ✅
...ages/babel-plugin-lingui-transform-js/src/index.js 100% <100%> (ø)
packages/lingui-react/src/Plural.js 100% <100%> (ø) ✅
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503608c...a274e40. Read the comment docs.

@tricoder42 tricoder42 merged commit 2a7cb29 into master Feb 12, 2017
@tricoder42 tricoder42 deleted the babel-plugin-i18n branch February 12, 2017 14:11
@tricoder42 tricoder42 mentioned this pull request Feb 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tricoder42